-
Notifications
You must be signed in to change notification settings - Fork 422
feat: replace kwargs with invocation_state in agent APIs #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can you add details to the PR description explaining the purpose of this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add unit tests for this
Actually this change is covered by origin test code but I can add a specific one |
Co-authored-by: Nick Clegg <nac542@gmail.com>
Co-authored-by: Nick Clegg <nac542@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
664381a
to
b14e2f5
Compare
b14e2f5
to
cf5d4bb
Compare
Description
The current Agent APIs (Agent.call, Agent.invoke_async, Agent.stream_async) accept arbitrary keyword arguments via **kwargs, which are then converted to invocation_state and passed through the execution pipeline to tools. This has the downside that any new parameter we want to add to these methods could potentially conflict with user-provided kwargs, making it impossible to evolve the API without breaking changes.
Change:
Add invocation_state as parameter to agent's APIs.
Still keep **kwargs for now to keep backward compatible, merge **kwargs to invocation_state instead.
Related Issues
#919
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.